Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conversion of GtsfmData Dictionaries to Lists #383

Open
travisdriver opened this issue Nov 17, 2021 · 0 comments
Open

Remove conversion of GtsfmData Dictionaries to Lists #383

travisdriver opened this issue Nov 17, 2021 · 0 comments

Comments

@travisdriver
Copy link
Collaborator

I spent a while trying to update the code so that we do not rely on converting the dictionary of cameras in GtsfmData to a List. However, almost all of the metric computation functions rely on Lists of Pose derived from the camera dictionary of GtsfmData.

I'm assuming this is why the _number_images attribute of the GtsfmData class was added in the first place: so that the cameras data could be converted to a list such that its the same length as the original ground truth data. I think this is should be saved for another PR.

I do think that using Dicts instead of Lists like Colmap is a lot better and should be implemented in the near future.

Originally posted by @travisdriver in #376 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant