Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table wrapping on page-14 #74

Open
aruhant opened this issue Dec 28, 2023 · 2 comments
Open

Table wrapping on page-14 #74

aruhant opened this issue Dec 28, 2023 · 2 comments

Comments

@aruhant
Copy link

aruhant commented Dec 28, 2023

There seems to be an issue with the margins of blue-table on page 14 (On the Subject of Wire Sequences).
The three tables do not fit the page width, and so the third table wraps below the first two. I have tested this in the latest chrome and safari, it is broken in both browsers.

The problem is present in the English template, and also in some of the translations (like this one https://bombmanual.github.io/italian/ ).

Can someone confirm that this is indeed an issue ? I'll be happy to submit a PR to fix it.

@aruhant
Copy link
Author

aruhant commented Dec 28, 2023

After looking further into the issue, I found the following:

Certain translations employ a more recent template, utilizing main.css for styling and main.js for autonumbering pages, resulting in a clean presentation without layout overflow on page-14.
On the flip side, the initial English template and some other translations utilize an older template, ironically named newmain.css. These templates manifest layout overflow issues on page 14.
Moving forward, it is recommended that any new translations adopt the more current template. Meanwhile, for translations using newmain.css, a practical solution would involve adjusting the margins of blue-table in the CSS. This approach carries minimal impact and won't disrupt the remainder of the page layout.

I am will make this change, conduct testing on existing translations, and subsequently submit a pull request.

@brugnara
Copy link
Member

brugnara commented Jan 4, 2024

Thank you for your effort and the explanation.

It could be for sure what you did write since some translations did not receive any update for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants