-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback/success message is never triggered #257
Comments
@eduardomart the boltforms templates are changed when going from 3.x to 4.x. One of these changes is that the messages are handled a bit differently. You probably need to rebuild the form customization templates based on the new boltforms templates. |
@eduardomart did you get any further with this? |
I did manage to upgrade to boltforms |
**EDIT: Nevermind this doesn't work all the time. Only sometimes, even after I changed the template to be almost the same. Also the data array in the email lacks all but one formfield. I'll give up now and roll my formcode. ** Would be great if this was clearly documented along with the other things I spent 5 hours on today (for instance "choice: content"): In your formfile replace: {{ form_start(form, {'attr': {'name': formname}}) }} |
@jadwigo, could you please elaborate on how to "rebuild the form customization templates based on the new boltforms templates"? I am currently on BoltForms v4.2.5, but as mentioned, the page seems to be reloading in place of the feedback showing. Edit: I tested a few versions of BoltForms, and this seems to be an issue starting at v4.2.4 as it's working in v4.2.3. |
Sure. If you have created custom templates for an older boltforms you need to start over fresh. Basically: make a copy of the new templates and do all your customizations again in the new templates. |
Thanks. I ended up rolling back to v4.2.3 for a quick fix, but I'll keep the refreshed custom template approach in mind for the future. |
@jadwigo @pragmaworking I have the same issue: feedback never shown after success submission. So I believe minor templates change as suggested by @jadwigo is not the root cause. [edit] Reverting back to 4.2.3, it looks the only solution right now |
I confirm this. On v4.2.6 the bug is still present: no feedback after successfull submission. v4.2.3...v4.2.6 - here you can see the difference between 4.2.3 and 4.2.6. As can be seen, the majority of changes only affect the docs. There are only minor changes in the source code, and they are the reason of the bug. V4.2.3 is the latest good-to-go version as of now. P.S. I never used old templates, I started with v4.2.5 right away and the bug has already been there. So dear devs, please look into this. Thanks. |
I think I've found the problem that causes it. |
Please disregard this. The master build is ancient. On the latest version, which is 4.2.6, the issue persists. 4.2.3 is still the latest version unaffected. |
I confirm that @SantinoPetrovic 's solution works (in v4.2.6). Thank you. |
Also can confirm @SantinoPetrovic 's fix worked perfect for me too on v 4.2.6 Thank you so much, this was driving me crazy and spent about 2 hours before finding this fix. |
Should be fixed in See: #284 |
This used to work in BF 3.x but now the 'Feedback' never gets displayed. The form simply refreshes after a successful submission, no feedback at all.
Workaround:
In
boltforms.form.yml
add theredirect
property underfeedback
, like so:In my case
page/contact
is the record that loads my contact form, so in its template I use the following code:That way the success message is only displayed when triggered by the success redirect.
The text was updated successfully, but these errors were encountered: