fix: refine the code of crosschain and oracle module (#136)

proto/cosmos/crosschain/v1/crosschain.proto

@@ -5,5 +5,6 @@ option go_package = "github.com/cosmos/cosmos-sdk/x/crosschain/types";
 
 // Params holds parameters for the cross chain module.
 message Params {
+  // initial balance to mint for crosschain module when the chain starts
   string init_module_balance = 1;
 }

proto/cosmos/crosschain/v1/query.proto

@@ -41,31 +41,38 @@ message QueryParamsResponse {
 
 // QueryCrossChainPackageRequest is the request type for the Query/CrossChainPackage RPC method.
 message QueryCrossChainPackageRequest {
+  // channel id of the cross chain package
   uint32 channel_id = 1;
+  // sequence of the cross chain package
   uint64 sequence   = 2;
 }
 
 // QueryCrossChainPackageResponse is the response type for the Query/CrossChainPackage RPC method.
 message QueryCrossChainPackageResponse {
+  // content of the cross chain package
   bytes package = 1;
 }
 
 // QuerySendSequenceRequest is the request type for the Query/SendSequence RPC method.
 message QuerySendSequenceRequest {
+  // channel id of the cross chain package
   uint32 channel_id = 1;
 }
 
 // QuerySendSequenceResponse is the response type for the Query/SendSequence RPC method.
 message QuerySendSequenceResponse {
+  // sequence of the cross chain package
   uint64 sequence = 1;
 }
 
 // QuerySendSequenceRequest is the request type for the Query/ReceiveSequence RPC method.
 message QueryReceiveSequenceRequest {
+  // channel id of the cross chain package
   uint32 channel_id = 1;
 }
 
 // QuerySendSequenceResponse is the response type for the Query/ReceiveSequence RPC method.
 message QueryReceiveSequenceResponse {
+  // sequence of the cross chain package
   uint64 sequence = 1;
 }

proto/cosmos/oracle/v1/tx.proto

@@ -21,13 +21,21 @@ message MsgClaim {
   option (gogoproto.equal)           = false;
   option (gogoproto.goproto_getters) = false;
 
+  // sender address of the msg
   string           from_address     = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
+  // source chain id
   uint32           src_chain_id     = 2;
+  // destination chain id
   uint32           dest_chain_id    = 3;
+  // sequence of the oracle channel
   uint64           sequence         = 4;
+  // timestamp of the claim
   uint64           timestamp        = 5;
+  // payload of the claim
   bytes            payload          = 6;
+  // bit map of the voted validators
   repeated fixed64 vote_address_set = 7;
+  // bls signature of the claim
   bytes            agg_signature    = 8;
 }
 

x/crosschain/types/keys.go

@@ -24,8 +24,6 @@ const (
 	SequenceLength       = 8
 
 	GovChannelId = sdk.ChannelID(9)
-
-	QueryParameters = "parameters"
 )
 
 var (

x/oracle/keeper/grpc_query_test.go

@@ -6,9 +6,9 @@ import (
 	"github.com/cosmos/cosmos-sdk/x/oracle/types"
 )
 
-func (suite *TestSuite) TestQueryParams() {
-	res, err := suite.queryClient.Params(gocontext.Background(), &types.QueryParamsRequest{})
-	suite.Require().NoError(err)
-	suite.Require().NotNil(res)
-	suite.Require().Equal(suite.app.OracleKeeper.GetParams(suite.ctx), res.GetParams())
+func (s *TestSuite) TestQueryParams() {
+	res, err := s.queryClient.Params(gocontext.Background(), &types.QueryParamsRequest{})
+	s.Require().NoError(err)
+	s.Require().NotNil(res)
+	s.Require().Equal(s.app.OracleKeeper.GetParams(s.ctx), res.GetParams())
 }

x/oracle/types/params.go

@@ -14,7 +14,6 @@ const (
 
 var (
 	KeyParamRelayerTimeout     = []byte("RelayerTimeout")
-	KeyParamRelayerBackoffTime = []byte("RelayerBackoffTime")
 	KeyParamRelayerRewardShare = []byte("RelayerRewardShare")
 	KeyParamRelayerInterval    = []byte("RelayerInterval")
 )