Middleware #9
Open
Middleware #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen pk is used all over the models.py file except in get_product. This generates errors if the product has not an id field (but another primary key). The proposed patch solves the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note Don't merge this yet, I created this pull request to track the idea, and am certain there is stuff to do.
This is a proposal for a middleware centric approach to the cart. The major differences are the removal of cart/cart.py (the relevant behavior is moved to models.Cart so there is only one kind of Cart object.) Determining which cart to use has been moved to a middleware which attaches the cart to the request. I believe that this should satisfy the requirement that most context_processors would satisfy, that you can retrieve the cart in the context as well (through ResponseContext.) Although I'm not certain about that last point and still need to look into it.