Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create helper functions for making soft signals #215

Closed
DominicOram opened this issue Apr 15, 2024 · 2 comments · Fixed by #217
Closed

Create helper functions for making soft signals #215

DominicOram opened this issue Apr 15, 2024 · 2 comments · Fixed by #217
Assignees
Labels
good first issue Good for newcomers hackathon Good issues for the upcoming bluesky hackathon

Comments

@DominicOram
Copy link
Contributor

Creating a soft signal is a bit long winded, we should make helper functions like https://github.com/DiamondLightSource/dodal/blob/main/src/dodal/devices/ophyd_async_utils.py

Acceptance criteria

  • There are helper functions in ophy-async for making soft signals
  • We remove the ones in dodal
@DominicOram DominicOram added good first issue Good for newcomers hackathon Good issues for the upcoming bluesky hackathon labels Apr 15, 2024
@coretl coretl moved this to Todo in Hackathon 2024 Apr 15, 2024
@callumforrester
Copy link
Contributor

Reviewers: @DominicOram @coretl @mrakitin

@callumforrester callumforrester moved this from Todo to In Progress in Hackathon 2024 Apr 15, 2024
@jsouter
Copy link
Contributor

jsouter commented Apr 15, 2024

See #217, as I say, can be moved if it's not core enough to be in core.signal. Will also make the equivalent import change in Dodal once I know the version number for ophyd_async with this change.

@jsouter jsouter moved this from In Progress to In Review in Hackathon 2024 Apr 16, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Hackathon 2024 Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hackathon Good issues for the upcoming bluesky hackathon
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants