Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't understand why you need algo files when js would be just fine #1

Open
totty90 opened this issue Mar 17, 2015 · 4 comments
Open

Comments

@totty90
Copy link

totty90 commented Mar 17, 2015

No description provided.

@pinhopro
Copy link
Member

That was a bad decision. Hard to change now :/

@totty90
Copy link
Author

totty90 commented Mar 18, 2015

I've noticed this and other issues. I would suggest to look into webpack + gulp to improve your code structure.

Also another tip would be to use standard names for things. For example classes are named like this: MyBot.js´ and notmy_bot.js. Also the instance of the class is like thisvar myBot = new MyBot()`.

I also don't understand the methods and properties with a ending _. I use these coding practices:

  • Private method/property: __myMethod;
  • Protected: _myMethod;
  • Public: myMethod;

@cesardeazevedo
Copy link

Hi @hems, can you tell me what's going on about the "API" link? I didn't have any problems, could you create an issue on our frontend repository?

Regarding the algorithm trading, we're currently working on a client javascript sdk and a better interface to run algorithms that enables you running them on a local server...

@hems
Copy link

hems commented Sep 7, 2016

@cesardeazevedo when i click "API" on https://foxbit.exchange it just links me to a #, i didn't check the other websites. Probably not a blinktrade problem, my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants