-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Rails 7.1 (+ Ruby 3.3 & Alpine 3.20) #1122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-ACTIONMAILER-8220269 - https://snyk.io/vuln/SNYK-RUBY-ACTIONPACK-8220162 - https://snyk.io/vuln/SNYK-RUBY-ACTIONPACK-8220268 - https://snyk.io/vuln/SNYK-RUBY-ACTIONTEXT-8220270
…5c0f85301d3324b71 fix: Gemfile & Gemfile.lock to reduce vulnerabilities
Ithanil
force-pushed
the
rails_7
branch
2 times, most recently
from
November 12, 2024 08:16
5c0f1a0
to
1df29a2
Compare
Ithanil
force-pushed
the
rails_7
branch
3 times, most recently
from
November 12, 2024 08:52
36f08cb
to
e1045e6
Compare
farhatahmad
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Rails from 6.1 to 7.1 and made relevant changes accordingly.
At the same time, Ruby was updated from 3.1 to 3.3, which didn't seem to have any relevant breaking changes, and Alpine was updated from 3.17 to 3.20 to support Ruby 3.3 (although a self-compiled version is used anyway in the Docker builds).
Notes for the Rails upgrade:
A few points in the above were relevant:
allow_other_host
or an exception will be raised. That is relevant for the redirect on join calls.MiniTest
is now namedMinitest
.... (that took me a while)config.active_record.default_column_serializer = YAML
Changes in default files generated by
rails app:update
have been reviewed and merged in as appropriate, maintaining any previous non-default configurations in most cases. One setting that has been changed in all files isconfig.cache_classes
replaced byconfig.enable_reloading
with inverted boolean value.The
app/schema.rb
has been updated with the output ofrake db:schema:dump
. For Scalelite, the only changes are that the schema now contains the Rails version (7.1) and how timestamp precision is handled (see here for a lengthy discussion).Multiple deprecation warnings that are now appearing in Rails test / Rspec runs are NOT addressed yet. Most of them have to be addressed for a move to 7.2 . I will open a corresponding issue mentioning all the deprecations.
As a result of the upgrades, security support is restored for Rails and also Ruby and Alpine. A further upgrade to Rails 7.2 in the near future will secure support until late 2026.
Testing Steps
More testing by another party would be welcome!
Fixed issues:
#1121