Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRCI - demo] Add a specific message for Access request when user doesn't have any data #268

Open
Clementinev opened this issue Dec 5, 2022 · 6 comments
Labels
effort2: medium (days) scope: privacy portal Related to the @blindnet/privacy-portal package type: enhancement Improve quality of an existing feature

Comments

@Clementinev
Copy link
Collaborator

Following our discussion on slack @jboileau99
On the demo, on the PRCI currently when a user who doesn't have any data submit an access request, there is no specific message saying that he doesn't have any data and he's shown with a link to download data that is empty -> when the request is processed, instead of the last message containing the download data link we could show specific message such as "The organisation doesn't have any data on you"/"L'organisation n'a aucune donnée sur vous"
access req no data

@Clementinev Clementinev added type: enhancement Improve quality of an existing feature scope: privacy portal Related to the @blindnet/privacy-portal package labels Dec 5, 2022
@Clementinev
Copy link
Collaborator Author

Clementinev commented Dec 6, 2022

Currently there is a bug when clicking on the download data link without any data, a blank screen shows up and stays blank when refreshing the page (it works well when user has data)
Screenshot access req no data link bug

@Clementinev
Copy link
Collaborator Author

access req with no data link bug

@jboileau99
Copy link
Collaborator

Currently there is a bug when clicking on the download data link without any data, a blank screen shows up and stays blank when refreshing the page (it works well when user has data) Screenshot access req no data link bug

@m4rk055 What does this error message in the browser mean? I can't replicate the situation even if I don't submit data and send an access request

@m4rk055
Copy link
Member

m4rk055 commented Dec 8, 2022

When the storage rejects an action, due to e.g. not having the requested data, PCE returns the message instead of the link in the data field. It's badly designed indeed.
Quick fix can be to inspect the data and if it contains http, make it clickable. If not, just display the message.

@m4rk055
Copy link
Member

m4rk055 commented Dec 13, 2022

I made a temporary fix, as described my last message

@Clementinev
Copy link
Collaborator Author

Clementinev commented Dec 14, 2022

Thank you it works well, I put here the french translation of the current message: "Aucune donnée n'a été trouvée pour l'utilisateur."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort2: medium (days) scope: privacy portal Related to the @blindnet/privacy-portal package type: enhancement Improve quality of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants