Run onLayout when video dimensions change (Android) #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slycoder
reviewed
Oct 31, 2019
| @@ -44,6 +46,13 @@ public void onFrameDimensionsChanged(int vw, int vh, int rotation) { | |||
| videoWidth = vw; | |||
| RNVideoViewGroup.this.forceLayout(); | |||
| } | |||
| new Handler(Looper.getMainLooper()).post(new Runnable(){ | |||
There was a problem hiding this comment.
Could this just be runOnUiThread?
gastonmorixe
force-pushed
the
master
branch
from
7c3cd06
to
bce7e78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #241
Currently on Android the aspect ratio of the video will be off if they are not the Twilio default, and nothing changes the container view.
This addition will run onLayout when the dimensions change so the video will always have the correct aspect ratio.