Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading images to tools + misc fixes. #122

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

destos
Copy link
Contributor

@destos destos commented Mar 12, 2019

Includes #120 can be merged first or together with this PR

Relies on: neutronX/django-markdownx/pull/153 being merged. Or we'll have to use a fork in the pyproject.toml

@jsatt
Copy link
Collaborator

jsatt commented Mar 12, 2019

I haven't looked at the code here yet, but could we make sure the support is for any type of file? We could then have a manager method to grab images (capture mimetype on upload? allow user to choose filetype?). This would allow for owners to upload files that aren't images like config files and calibration templates. These extra files could then be included in a sidebar on the tool page.

@destos
Copy link
Contributor Author

destos commented Mar 14, 2019

@jsatt Sure, I can probably do some multi-table stuff with the File/Photo model. Currently, the interface for uploading images is drag and drop into the markdown editor. Should we add another attachment area instead for the other files?

@jsatt
Copy link
Collaborator

jsatt commented Mar 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants