Fix concurrent retrieve product request #675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift’s ownership rule is that a value can be simultaneously accessed by multiple readers or a single writer - https://developer.apple.com/forums/thread/682446?answerId=678850022#678850022
…rieveProductsInfo execution before fireCallbacks() by DispatchGroup - groupFire
|
I also experienced these crashes, would be good to get this PR merged |
NikKovIos
reviewed
Jan 16, 2023
| @@ -49,7 +49,20 @@ class ProductsInfoController: NSObject { | |||
| } | |||
|
|
|||
| // As we can have multiple inflight requests, we store them in a dictionary by product ids | |||
| private var inflightRequests: [Set<String>: InAppProductQuery] = [:] | |||
| private var _inflightRequests: [Set<String>: InAppProductQuery] = [:] | |||
There was a problem hiding this comment.
_ is a rudiment from obj_c. rename please without underscore.
bivant
force-pushed
the
fix_concurrent_retrieveProductRequest
branch
from
0c33030
to
72d7e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on changes from #674
Test for concurrent retrieveProductRequest is very unstable - it crashes on read/write to the controller.inflightRequests and builder.request