-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-10600] Push notification with full notification center content #5086
base: km/pm-10600
Are you sure you want to change the base?
Conversation
Notification Center push notification now includes all the fields.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## km/pm-10600 #5086 +/- ##
===============================================
+ Coverage 43.30% 43.31% +0.01%
===============================================
Files 1412 1412
Lines 64887 64917 +30
Branches 5935 5936 +1
===============================================
+ Hits 28099 28120 +21
- Misses 35550 35560 +10
+ Partials 1238 1237 -1 ☔ View full report in Codecov by Sentry. |
New Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. KM team for full review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10600
This is Part 2.
See Part 1: #4923
See Part 3: #5057
📔 Objective
Notification Center push notification now includes all the fields.
The push notification have a limit of 4KB for payload (limitation of Azure Notification Hub, FCM and APNS). For notification center push notification, only
Body
field needs to have a max length, since other fields have deterministic max length. No other push notifications are affected.To fix this, a separate PR will follow once the API PR is merged #4852 that will have the max length of 3000 on the
Body
field in the request and optionally in db column too.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes