Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TransactionBuilder.js #138

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

grctest
Copy link
Contributor

@grctest grctest commented Oct 13, 2024

Addresses issue: #137

When creating a proposal, we were incorrectly formatting nested proposal fee asset id's as "1.3.1.3.0" for example, now it's just the fee asset id which fixes the encountered issue.

@grctest
Copy link
Contributor Author

grctest commented Oct 15, 2024

@svk31 Hey, do you agree on the solution to this bug? Thanks

@sschiessl-bcp
Copy link
Contributor

Hi there @grctest ,

did you check in the bitshares-ui how this part is used for proposals? Does the ui only send the number without 1.3.? Proposals have been working from there in the past

@grctest
Copy link
Contributor Author

grctest commented Nov 4, 2024

We could do the following instead? That way the UI wouldn't need to be updated.

const _id= proposal.op[1].fee.asset_id;
proposalFeeAssets.push(`${!_id.includes("1.3.") ? "1.3." : ""}${_id}`);

That way the existing UI component wouldn't need to be updated.

Updated to maintain reference UI compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants