Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review exception handling #3

Open
abahgat opened this issue May 2, 2013 · 0 comments
Open

Review exception handling #3

abahgat opened this issue May 2, 2013 · 0 comments

Comments

@abahgat
Copy link
Member

abahgat commented May 2, 2013

Most methods in weupnp throw underlying exceptions as they are, without dealing with or wrapping them.

It might be worth considering building a generic weupnp exception, in order to simplify the error handling logic of the calling code.

This will break backwards compatibility for existing users, so we must publish that accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant