Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customize store UI (theming support) #319

Open
1 of 4 tasks
Tracked by #317
MrNaif2018 opened this issue Oct 1, 2021 · 11 comments
Open
1 of 4 tasks
Tracked by #317

Add ability to customize store UI (theming support) #319

MrNaif2018 opened this issue Oct 1, 2021 · 11 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MrNaif2018
Copy link
Member

MrNaif2018 commented Oct 1, 2021

Also tracked in bitcart/bitcart#166

We need to add ability to customize theme colors of the store (for custom brands). Probably the best solution is to use css variables.

I have implemented basic theming support in 3730413 and 1d02318

There are few things left to make it fully customizeable:

:root {
  --brand-color: #162d50;
  --primary: var(--brand-color) !important;
  --success: var(--brand-color) !important;
  --link: var(--brand-color) !important;
}

The css should be loaded dynamically via head function inside default layout.
Css file url itself is a variable got from store object.
Merchants API needs to be customized to add new store theming settings, see bitcart/bitcart#244

  • And if all of the above is implemented, we could try to allow using bulmaswatch for easily selecting themes. This means that some existing styles might need to be customized to allow this

Note that all themes being applied should happen at the runtime, so at sass compilation step we should provide all needed css variables for modification later

@MrNaif2018
Copy link
Member Author

MrNaif2018 commented Oct 10, 2021

@beatrizsmerino Assigning you there (even though it is not required) :D
EDIT: please comment on the issue for me to be able to assign you if you need it

@beatrizsmerino
Copy link

thanks !! :)
I'm reading the requirements and making a fork of the project

@beatrizsmerino
Copy link

image
I'm having problems for run the project npm run dev

@MrNaif2018
Copy link
Member Author

Yeah sorry for that, it needs to be fixed. There is an open issue for that, but I was waiting if someone would take it up (:
#318
See #316 (comment) this guide on how to set up merchants api
Also we use yarn, it is recommended to not mix package managers' lock files

@MrNaif2018
Copy link
Member Author

Hi @beatrizsmerino! Do you have any questions so far? Were you able to run the app without the connection error?

@beatrizsmerino
Copy link

Hi @beatrizsmerino! Do you have any questions so far? Were you able to run the app without the connection error?

sorry, I have not yet been able to run the project.

@MrNaif2018
Copy link
Member Author

Let me know if you have any issues.
I have documented how to run admin panel here:
https://github.com/bitcartcc/bitcart-admin/blob/master/CONTRIBUTING.md#merchants-api
For store, replace BITCART_ADMIN_API_URL with BITCART_STORE_API_URL

@MrNaif2018
Copy link
Member Author

Hi @beatrizsmerino! Have you been able to look at this? Do you need some help?

@beatrizsmerino
Copy link

I haven't been able to get on it yet, I've been busy, but I will do it this week.

@beatrizsmerino
Copy link

In the end I don't have time to do it, sorry.

@MrNaif2018
Copy link
Member Author

Sure. It will get implemented by itself gradully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants