-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to customize store UI (theming support) #319
Comments
@beatrizsmerino Assigning you there (even though it is not required) :D |
thanks !! :) |
Yeah sorry for that, it needs to be fixed. There is an open issue for that, but I was waiting if someone would take it up (: |
Hi @beatrizsmerino! Do you have any questions so far? Were you able to run the app without the connection error? |
sorry, I have not yet been able to run the project. |
Let me know if you have any issues. |
Hi @beatrizsmerino! Have you been able to look at this? Do you need some help? |
I haven't been able to get on it yet, I've been busy, but I will do it this week. |
In the end I don't have time to do it, sorry. |
Sure. It will get implemented by itself gradully |
Also tracked in bitcart/bitcart#166
We need to add ability to customize theme colors of the store (for custom brands). Probably the best solution is to use css variables.
I have implemented basic theming support in 3730413 and 1d02318
There are few things left to make it fully customizeable:
Currently for example switch color is still green even when success color of the theme was changed to another color, see:
https://github.com/Wikiki/bulma-switch/blob/master/src/sass/index.sass#L1
First of all to make it all work, we need to remove stylus and use sass everywhere, see Migrate all stylus styles to sass #316
After that we need to ensure that sass customizations get applied to component scoped styling.
If not all components styling can be moved to
main.sass
filehttps://github.com/bitcartcc/bitcart-store/blob/1d023187d32fa08bf4043badc2137e6b4a18979b/components/Switch.vue#L25
Also probably we should import not from css, but from source sass files to be able to customize some variables
If it still doesn't work, we might need to expose more colors to customization or change switch-background variable to use some color like $primary instead of $grey-light
https://github.com/bitcartcc/bitcart-store/blob/1d023187d32fa08bf4043badc2137e6b4a18979b/bulma-css-vars.config.js#L4-L17
Also maybe there could be a better way to not hardcode hsl values of colors
The css should be loaded dynamically via
head
function inside default layout.Css file url itself is a variable got from store object.
Merchants API needs to be customized to add new store theming settings, see bitcart/bitcart#244
Note that all themes being applied should happen at the runtime, so at sass compilation step we should provide all needed css variables for modification later
The text was updated successfully, but these errors were encountered: