Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename dynup params #476

Closed
wants to merge 28 commits into from
Closed

Rename dynup params #476

wants to merge 28 commits into from

Conversation

val-ba
Copy link
Contributor

@val-ba val-ba commented Jun 5, 2024

Summary

Some parameter names are a bit confusing, so we want to rename them or add more thorough descriptions.

Proposed changes

Related issues

Fixes #429

Checklist

  • Run colcon build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

JanNiklasFeld and others added 28 commits April 19, 2024 15:03
@JanNiklasFeld
set up dynamic reconfigure
4154e6b
@JanNiklasFeld
errors remaining that jan-niklas can't solve
3cdfce0
@val-ba
move parameters config and rename
6d68a12
@val-ba
add parameter library dependencies to cmake and packgexml
c491613
@val-ba
add dynamic reconfigure to dynup engine and node
4b350e0
@val-ba
add dynup stabilizer dynamic reconfigure
0d08e49
@JanNiklasFeld
set default values for the parameters
ccacd9e
@val-ba
add previously deleted variables
1aa2c59
@val-ba
update namespace to be the same
a24183e
@val-ba
change sim params to have same form as other params
f1101c5
@val-ba
add move_group node
1bfff9b
@val-ba
remove timer for loop
97a62eb
@val-ba
Merge branch 'main' into feature/dynamic_reconfigure_dynup
857a8e0
@val-ba
use sim time in sim for dynup
11a23ac
@val-ba
declare parameters differently
1b1e837
@val-ba
remove unused loop function
8fa6296
@val-ba
remove a parameter which is now unused
ce8b636
@val-ba
remove or translate german comments
823e664
@Flova
Merge branch 'main' into feature/dynamic_reconfigure_dynup
423f82c
@val-ba
run make format
506c353
@val-ba
merge main
fbbd3a0
@val-ba
only use seperate conifg for sim params which differ
4028b51
@val-ba
add some parameter descriptions, but need to be updated
178de51
@val-ba
be more conistent with parameter usage
53930a7
@val-ba
remove comments
0123a75
@val-ba
only use stabilzer params in stabilzer
4fd5ef2
@val-ba
run make format
87f1729
@val-ba
update some parameter descriptions
aa73d3c
@val-ba val-ba added the docs label Jun 5, 2024
@val-ba val-ba self-assigned this Jun 5, 2024
@jaagut jaagut closed this Jun 28, 2024
@jaagut jaagut deleted the feature/rename_dynup_params branch June 28, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@val-ba val-ba

@ayin21 ayin21

Labels
docs motion
Projects
Software
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor dynup params
6 participants
@val-ba @texhnolyze @jaagut @ayin21 @JanNiklasFeld @Flova