Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-confirm Fails if Just 1 of the Configured XMR Explorers is Offline #7261

Open
suddenwhipvapor opened this issue Sep 29, 2024 · 2 comments

Comments

@suddenwhipvapor
Copy link
Contributor

Description

Reporting on a user's behalf:
I'm aware of the changes with the node provider and I can confirm this issue exists regardless of which node is used (I have even tried it with a local node). The issue is with the app code, as I stated, which gives up the moment any 1 of the XMR explorers return an UNRELATED error (meaning the error is OTHER THAN that they couldn't find the referenced transaction).
I'm going through the logs, and I must say it would take me multiple hours to scrub the logs of the private data since it is interspersed throughout. Also, nothing in the logs shows the exact error that was shown to me in the UI, something to the effect of "auto confirm not possible for this transaction". I have the full logs from the moment the Buyer sent the XMR to me until the very end, when I manually clicked the Payment Received button after seeing 10+ confirmations and the UI error.

The logs do show that 2 our of my 4 configured XMR explorers were indeed showing the correct status of the transaction with the buyer's posted tx ID and key. But auto confirm was denied because the other 2 explorers were not reachable.

Version

latest

Steps to reproduce

Expected behaviour

Actual behaviour

Screenshots

Device or machine

Additional info

@suddenwhipvapor suddenwhipvapor changed the title XMR auto-confirm: one bad apple xmr node spoils the bunch, and trade is not confirmed Auto-confirm Fails if Just 1 of the Configured XMR Explorers is Offline Oct 2, 2024
@pazza83
Copy link

pazza83 commented Oct 12, 2024

@suddenwhipvapor do you know if this going to be fixed in the next release with the removal of the outdated nodes and the inclusion of your own?

@suddenwhipvapor
Copy link
Contributor Author

@suddenwhipvapor do you know if this going to be fixed in the next release with the removal of the outdated nodes and the inclusion of your own?

not sure, I would expect this to be the case as long as all preconfigured xmr explorer nodes are online

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@pazza83 @suddenwhipvapor and others