Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variant region condition for dups ending in UTR #716

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Add variant region condition for dups ending in UTR #716

merged 3 commits into from
Jun 4, 2024

Conversation

b0d0nne11
Copy link
Contributor

@b0d0nne11 b0d0nne11 commented Jan 4, 2024 •
edited
Loading

Fixes #715.

Classify ins or dup variants as 3'UTR if the end position is in the UTR region regardless of the start position.

@b0d0nne11 b0d0nne11 requested a review from reece as a code owner January 4, 2024 20:32
@b0d0nne11
Copy link
Contributor Author

Including ins here as per my comment on the related issue.

@b0d0nne11 b0d0nne11 requested a review from a team as a code owner January 23, 2024 19:27
reece
reece reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@reece reece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment in #715

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Apr 5, 2024
@jsstevenson jsstevenson removed the stale Issue is stale and subject to automatic closing label Apr 5, 2024
@jsstevenson jsstevenson added the keep alive exempt issue from staleness checks label Apr 22, 2024
@b0d0nne11
Copy link
Contributor Author

Rebased on main

andreasprlic
andreasprlic approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@andreasprlic andreasprlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these changes look good to me.

@andreasprlic andreasprlic mentioned this pull request Jun 1, 2024
Closed
@jsstevenson jsstevenson merged commit 575fa97 into biocommons:main Jun 4, 2024
5 checks passed
@holtgrewe holtgrewe mentioned this pull request Jul 24, 2024
Closed
holtgrewe added a commit to varfish-org/hgvs-rs that referenced this pull request Jul 25, 2024
@holtgrewe
feat: add variant region condition for dups ending in 3' UTR (#192) (#…
362909c 
…195)

This corresponds to issue biocommons/hgvs#715 and PR biocommons/hgvs#716.

- biocommons/hgvs#715
- biocommons/hgvs#716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reece reece reece left review comments

@andreasprlic andreasprlic andreasprlic approved these changes

Assignees
No one assigned
Labels
keep alive exempt issue from staleness checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

c_to_p for dups that start in transcript but end in UTR
4 participants
@b0d0nne11 @reece @andreasprlic @jsstevenson