Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-package.yml #68

Merged
merged 9 commits into from
Sep 11, 2024
Merged

Update python-package.yml #68

merged 9 commits into from
Sep 11, 2024

Conversation

andreasprlic
Copy link
Member

I think we need this change to fix the deploy action

I think we need this change to fix the deploy action
@andreasprlic andreasprlic requested a review from a team as a code owner September 6, 2024 04:45
@jsstevenson
Copy link
Contributor

@korikuzma maybe this is a good time to add the trusted publishing component from the example repo?

@korikuzma
Copy link

@jsstevenson I agree. @reece would you be able to add trusted publishing on pypi?

@korikuzma
Copy link

@andreasprlic trusted publishing has been setup on pypi. Would you be able to update the file using the example here? You'll only need to change this line: https://github.com/biocommons/biocommons.example/blob/main/.github/workflows/python-package.yml#L129

@bsgiles73
Copy link

@reece I was not able to reproduce the local unit test error that you ran into in today's collective coding meeting.

(3.11) sgiles-MD6M:bioutils shane.giles$ make test
Using Python 3.11
pytest
============================================================================================= test session starts =============================================================================================
platform darwin -- Python 3.11.4, pytest-7.4.4, pluggy-1.5.0 -- /Users/shane.giles/locus/opt/repos/biocommons/bioutils/venv/3.11/bin/python3.11
cachedir: .pytest_cache
rootdir: /Users/shane.giles/locus/opt/repos/biocommons/bioutils
configfile: pyproject.toml
testpaths: tests
plugins: optional-tests-0.1.1, cov-4.1.0
collected 22 items

tests/test_normalize.py::test_trim[normalize_fn0] PASSED
tests/test_normalize.py::test_trim[normalize_fn1] PASSED
tests/test_normalize.py::test_anchor[normalize_fn0] PASSED
tests/test_normalize.py::test_anchor[normalize_fn1] PASSED
tests/test_normalize.py::test_trinuc PASSED
tests/test_normalize.py::test_bounds PASSED
tests/test_normalize.py::test_no_trim_no_shuffle PASSED
tests/test_normalize.py::test_shuffle_no_trim PASSED
tests/test_normalize.py::test_mode_string PASSED
tests/test_normalize.py::test_input_alleles_not_modified PASSED
tests/test_normalize.py::test_error_distinct[normalize_fn0] PASSED
tests/test_normalize.py::test_error_distinct[normalize_fn1] PASSED
tests/test_normalize.py::test_error_ref_allele PASSED
tests/test_normalize.py::test_error_vcf_mode_no_trim PASSED
tests/test_seqfetcher.py::test_fetch_seq PASSED
tests/test_seqfetcher.py::test_fetch_seq_ncbi_invalid_positions PASSED
tests/test_seqfetcher.py::test_add_eutils_api_key PASSED
tests/test_seqfetcher.py::test_fetch_seq_errors PASSED
tests/test_seqfetcher.py::test_rate_limit PASSED
tests/test_sequences.py::test_translate_examples PASSED
tests/test_sequences.py::test_translate_selenoproteins PASSED
tests/test_sequences.py::test_translate_vertebrate_mitochondrial PASSED/Users/shane.giles/locus/opt/repos/biocommons/bioutils/venv/3.11/lib/python3.11/site-packages/coverage/control.py:894: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")


---------- coverage: platform darwin, python 3.11.4-final-0 ----------
Name                              Stmts   Miss  Cover
-----------------------------------------------------
src/bioutils/__init__.py              3      3     0%
src/bioutils/_versionwarning.py       7      7     0%
src/bioutils/accessions.py           36     36     0%
src/bioutils/assemblies.py           21     21     0%
src/bioutils/coordinates.py           7      7     0%
src/bioutils/cytobands.py            14     14     0%
src/bioutils/digest.py               25     25     0%
src/bioutils/digests.py              28     28     0%
src/bioutils/exceptions.py            2      2     0%
src/bioutils/normalize.py           131    131     0%
src/bioutils/seqfetcher.py           71     71     0%
src/bioutils/sequences.py           101    101     0%
src/bioutils/vmc_digest.py           11     11     0%
-----------------------------------------------------
TOTAL                               457    457     0%


============================================================================================= 22 passed in 1.94s ==============================================================================================

@korikuzma
Copy link

@bsgiles73 same

@andreasprlic
Copy link
Member Author

andreasprlic commented Sep 10, 2024

@korikuzma I replaced the python-package.yml with the one from the template and updated the pypi bioutils URL accordingly. It looks like it needs a few more tweaks though.

Copy link

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad, didn't see tests are failing now

@andreasprlic
Copy link
Member Author

@korikuzma after a few more tweaks (in Makefile), tests are passing.

@andreasprlic andreasprlic merged commit 6ccb466 into main Sep 11, 2024
9 checks passed
@andreasprlic andreasprlic deleted the andreasprlic-patch-1 branch September 11, 2024 14:47
@korikuzma korikuzma mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants