Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing save and ignoring the error when editing contact allows duplicate email to be shown #18

Open
SayYesToTrees opened this issue Mar 3, 2024 · 1 comment

Comments

@SayYesToTrees
Copy link

SayYesToTrees commented Mar 3, 2024

Hey guys!

Working through the book and loving it!

I noticed that in the edit functionality if you ignore the errors for a duplicate or empty field it shows the incorrect information when you then press back. It is visible with the duplicate in the list. I thought it was just my code so I cloned the repo but it seems to have the same bug.

Screenshot from 2024-03-02 19-13-59

Screenshot from 2024-03-02 19-14-17

@SayYesToTrees
Copy link
Author

It doesn't look like it actually saves it to contacts.json but shows incorrect email on /contacts route even on refresh. If I shut down the flask server and restart it. it reverts to the correct email.

@SayYesToTrees SayYesToTrees changed the title Pressing save and ignoring the error when editing a contact saves with a duplicate email Pressing save and ignoring the error when editing contact allows duplicate email to be shown Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant