-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should make clear what is technology type #727
Comments
We definitely should improve documentation of technology type because right now it is listed as a required column in template part of the doc but at the same time it's hard to understand what values it should have. P.S. I missed the discussion on making technology type required, I am guessing this is for compatibility with non-proteomics formats? As for the column order, it makes sense to have it close to assay name, but I find it hard to come up with arguments for one particular ordering. I don't know if it's a good idea to leave it unspecified so I suggest we should just pick one and stick with it. |
Yes. Also, the SDRF-proteomics may start getting used in other proteomics technologies that are not only MS, then it would be good to control the type of technology that was used. For example, we are working now to get Affinity proteomics Olink data in SDRF, then would be good to keep this field to control that.
I think the other is nice to be before Then, before |
One could say that |
I believe it's better to put it before the assay name, it makes more sense to know the technology used to process the sample. In most of the PRIDE submissions, submitters define which technology they have used in 'Sample processing protocol'. |
Including the assay name after the technology type in a proteomics experiment can be a helpful practice, especially for maintaining clarity and organization in data records. If you're managing a large dataset with multiple runs under the same technology, adding the assay name after the technology type can aid in distinguishing between them and facilitate data processing or interpretation. |
@nithujohn @deeptijk @levitsky what about allowing it right |
Fine by me. I think column order only matters for human readability. Most humans don't seem to notice the difference as long as the columns are next to each other, which is why we ended up with contradictions between the templates, validation rules and actual annotations in the first place. |
Before or after assay name are little difference. But one thing is that it often placed after the assay name like this https://ftp.ebi.ac.uk/biostudies/fire/E-MTAB-/567/E-MTAB-13567/Files/E-MTAB-13567.sdrf.txt. So I'm not sure it's mandatory in ArrayExpress and affects compatibility if it's put up front. I don't see MAGE-TABE validator forcing this order of term. I also agree before or after are fine. |
I would suggest like in my previous comment assay name after technology type |
I would also suggest to have assay name after the technology type. As mentioned by @ypriverol and @nithujohn ..it would be easier to handle larger datasets and conceptually it makes more sense to me. |
@deeptijk @levitsky @daichengxin @nithujohn: I think the best solution is to write it after the Please those in favour of the proposal vote here with 👍 if not, please continue commenting on the issue. I will update a PR about it. |
technology type is mandatory in SDRF but no section in the SDRF mentions it, and even when it is added to the templates, we have confusion about where should be. The validator says after the assay name, but the templates are before. see issue bigbio/sdrf-pipelines#177.
Let us include a section of the SDRF about
technology type
and also where to write it. I prefer before the assay name as the templates.Opinions @daichengxin @TineClaeys @levitsky
The text was updated successfully, but these errors were encountered: