-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose the proper form to evaluate #32
Comments
@tomaskulich yep, this is definitely the tricky part thanks for the bump. I think the topline search is adequate as this is what |
Well, if I understand correctly what the plugin is trying to do, then the |
@tomaskulich I'm thinking the best thing here might be like you proposed, to count parens until we hit the next opening |
The proposed solution is what atom-parinfer does 👍 |
@shaunlebron good to know thanks! |
modify SelectFullForm to not rely on paren matching partially solves #32
ok, I did this: 8c5269b. Could be few edge cases still left, although this definitely works smoother |
searching opening '(' on the first line seems like a decent heuristics for the beginning of the form.
The bottomline however is searched for badly. Searching for corresponding ')' may not work, because there may not yet be corresponding closing bracket:
Good idea may be to look for the next opening bracket on the first line (i.e. beginning of the next 'main' form) (or the end of file if not existing). I'm not sure how to implement this in vimscript though.
The text was updated successfully, but these errors were encountered: