Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ilmenite-Cookie-Consent with Litespeed cache #58

Open
Lovqvist opened this issue Nov 12, 2022 · 3 comments
Open

Ilmenite-Cookie-Consent with Litespeed cache #58

Lovqvist opened this issue Nov 12, 2022 · 3 comments
Assignees
Labels

Comments

@Lovqvist
Copy link

Hi,
We have some problems with the plugin when it comes to cashing the website, in our case we use litespeed cash.

When a visitor comes to the page, the cookie banner should appear and all scripts should be under the Blacklist in Yett until the user has approved cookies and the script then ends up under whitelist.

It now turns out that when the visitor then approves cookies and later on triggers a new cashing, the next visitor then also receives all scripts under whitelist and the person is not faced with the question of whether he wants cookies or not.

We then thought we had found a solution in Litespeed. They have a field where you can write excluded arguments. We put in ilcc_has_preferences". It now turns out that visitors who accept cookies now never get a cached version of the page, which now makes the page slow for users who accept cookies.

Do you have any suggestions on how we could solve this?

@ErikBernskiold
Copy link
Member

Hej!

I've given this some thought, and yes, clearly, this is a fault with the current client-server mixed design. We'll explore a client-only side solution to this. Hoping that this won't be too complicated actually. Thanks for catching this and sending over!

@ErikBernskiold ErikBernskiold self-assigned this Nov 13, 2022
@ErikBernskiold ErikBernskiold changed the title Ilmenite-Cookie-Consent with Litespeed cashe Ilmenite-Cookie-Consent with Litespeed cache Nov 13, 2022
@ErikBernskiold
Copy link
Member

I'd be curious, @Lovqvist, if you could give https://github.com/bernskioldmedia/Ilmenite-Cookie-Consent/tree/58-ilmenite-cookie-consent-with-litespeed-cache a try. I'm attempting to move the allow/disallow-list to a client decision here, but would love your additional tests.

Not convinced we've got all side-effects under control yet.

To test:

  1. Clone the branch
  2. Run the npm run release command.

@Lovqvist
Copy link
Author

Thank you for your quick support!

I have tested this now and I can't see any changes. It behaves exactly as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants