You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been trying to use the module with react-admin-firebase, however react-admin-firbease does return objects for the getMany calls (with just ids) even if those do not exist, which forced me to use the getOne instead.
However, It seems that when resource is successfully obtained via getOne the id is marked as non colliding, and when there is an error when querying the resource it is marked as colliding, which is the exact opposite of how it should work.
Is this repository dead? this doesn't seem like that much of an issue to fix this bug. Why should a function return the id if the app did find an object with the same id, and not return it otherwise.
I've been trying to use the module with react-admin-firebase, however react-admin-firbease does return objects for the getMany calls (with just ids) even if those do not exist, which forced me to use the getOne instead.
However, It seems that when resource is successfully obtained via getOne the id is marked as non colliding, and when there is an error when querying the resource it is marked as colliding, which is the exact opposite of how it should work.
react-admin-import-csv/src/import-controller.ts
Lines 65 to 67 in d85b212
Simply replacing the return value of then with return value of catch and vice verse should fix the issue.
The text was updated successfully, but these errors were encountered: