Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering of commands #126

Open
Beanow opened this issue Feb 25, 2015 · 2 comments
Open

Ordering of commands #126

Beanow opened this issue Feb 25, 2015 · 2 comments

Comments

@Beanow
Copy link

Beanow commented Feb 25, 2015

The ordering seems to cause some issue.
For example:

{
    "phpcs_sniffer_run": true,
    "phpcs_command_on_save": false,
    "phpcs_show_errors_on_save": false,
    "php_cs_fixer_on_save":true,
    "phpmd_run": true,
    "phpmd_command_on_save": true
}

This will add the mess detector markers, but remove them shortly after if the cs fixer makes any changes to the file. Ideally some form of ordering is available to be able to customize this behaviour.

@benmatselby
Copy link
Owner

@Beanow Hi there

I've just been looking into this and it's an interesting one. Technically the php-cs-fixer is running first, from what I can see, but the sniffers run after but don't see the fixer change.. I see the opposite of you. So I actually see the markers in the gutter, but they are wrong, because the fixer has fixed the issues.

So are you wanting to run the fixer, and then see what sniffs are found afterwards?

@Beanow
Copy link
Author

Beanow commented Sep 5, 2015

Yes, I think the fixer settings are easy to define and predictable. I would expect it to 'silently' fix them and sniff afterwards.

Ben Selby notifications@github.com schreef op 24 augustus 2015 22:05:27 CEST:

@Beanow Hi there

I've just been looking into this and it's an interesting one.
Technically the php-cs-fixer is running first, from what I can see, but
the sniffers run after but don't see the fixer change.. I see the
opposite of you. So I actually see the markers in the gutter, but they
are wrong, because the fixer has fixed the issues.

So are you wanting to run the fixer, and then see what sniffs are found
afterwards?


Reply to this email directly or view it on GitHub:
#126 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants