Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_company! to work without Ecto #672

Closed
doomspork opened this issue Mar 4, 2023 · 3 comments
Closed

Update get_company! to work without Ecto #672

doomspork opened this issue Mar 4, 2023 · 3 comments
Labels
bug Something isn't working enhancement A new feature or enhancement to the existing functionality help wanted Get involved! We'd love to have your help.

Comments

@doomspork
Copy link
Member

https://github.com/beam-community/elixir-companies/blob/main/lib/companies/companies.ex#L55-L71
@doomspork doomspork added bug Something isn't working enhancement A new feature or enhancement to the existing functionality help wanted Get involved! We'd love to have your help. labels Mar 4, 2023
@vvuunnqq
Copy link
Contributor

vvuunnqq commented Mar 13, 2023 •
edited
Loading

Hi, is this func used for query+update company profile?
If yes, I think the id should be related to company files name in priv/companies.

@doomspork
Copy link
Member Author

Howdy @vvuunnqq! We don't allow updating companies via the site at this point so that usage is no longer necessary. I believe this is only used when we use the show route for a company.

If yes, I think the id should be related to company files name in priv/companies.

Agreed! Happy to yield to you here. We did discuss slugs before: #588

@vvuunnqq
Copy link
Contributor

hmmm, I'm not sure at all, just create a PR #679 to support url slug 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement A new feature or enhancement to the existing functionality help wanted Get involved! We'd love to have your help.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doomspork @vvuunnqq