Feat: Implement CHES email notification #1313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2024 03:40
…on User-Selected Actions #1148
dhaselhan
reviewed
Nov 30, 2024
dhaselhan
reviewed
Nov 30, 2024
|
|
||
| # CHES configuration | ||
| self.config = { | ||
| "AUTH_URL": os.getenv("CHES_AUTH_URL", ""), |
There was a problem hiding this comment.
Currently all of our ENV vars start with LCFS_ and are mapped into settings.py, should we follow that pattern here?
dhaselhan
requested changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1148
secrets can be found here.
lcfs-email-service-dev
note: view component is only for testing.