Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCFS-1280: Fuel supply validation #1312

Open
wants to merge 2 commits into
base: release-0.2.0
Choose a base branch
from
Open

LCFS-1280: Fuel supply validation #1312

wants to merge 2 commits into from
+30 −4

Conversation

areyeslo
Copy link
Collaborator

  • The default Quantity supplied value being 0 should not be allow.
  • Zero should not be a valid amount in a fuel supply record and the row should not save until the user has entered a value.

Story

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

Backend Test Results

431 tests  ±0   431 ✅ ±0   1m 33s ⏱️ +2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 601658a. ± Comparison against base commit 81a395b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

Frontend Test Results

  1 files  ±0  114 suites  ±0   36s ⏱️ ±0s
367 tests ±0  347 ✅ ±0  20 💤 ±0  0 ❌ ±0 
369 runs  ±0  349 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 601658a. ± Comparison against base commit 81a395b.

♻️ This comment has been updated with latest results.

@areyeslo areyeslo force-pushed the LCFS-1280-FuelSupplyValidation branch 2 times, most recently from 9cbc7b3 to b179102 Compare November 29, 2024 19:16
@prv-proton prv-proton self-requested a review November 29, 2024 19:31
prv-proton
prv-proton requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@prv-proton prv-proton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation @areyeslo, but I think this ticket is focused on "Supply of fuel". Can you please confirm with Al, and make necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prv-proton prv-proton prv-proton requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@areyeslo @prv-proton