Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base model class for Well and Submission models #2278

Open
3 tasks
lunamoonmoon opened this issue Jul 15, 2024 · 1 comment
Open
3 tasks

Base model class for Well and Submission models #2278

lunamoonmoon opened this issue Jul 15, 2024 · 1 comment

Comments

@lunamoonmoon
Copy link
Contributor

lunamoonmoon commented Jul 15, 2024

Describe the task
Consider having Well and Submission in backend/wells/models.py extend off a common base class, given that they mostly have the exact same fields

Purpose

  • Cleaner code, mentioned in the repo as a comment
  • These classes are closely related, but if they are to diverge, it can cause errors

Acceptance Criteria

  • Create a base class with the fields used by both well and submission models
  • Create a well model which extends off this base and adds unique fields
  • Create a submission model which extends off this base and adds unique fields

Additional context

  • Image
  • Would need to look deeper into the inheritance of the classes
@Keegnan
Copy link

Keegnan commented Jul 31, 2024

Unless this becomes an issue, we are unlikely to address it. Will reconsider if anything changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants