Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): make loopback edges appear nicely #998

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

atyshka
Copy link

@atyshka atyshka commented Jun 19, 2023

🚀 What's changed?

  • Loopback edges (same source and destination) now render nicely
    Original:
Screen Shot 2023-06-19 at 12 07 03 PM

New:
Screen Shot 2023-06-19 at 12 04 03 PM

🐛 Fixes

  • Loopback edges previously were invisible as they rendered behind the node. This routes the edge around the left side.

🪴 To-Dos

  • This currently only works for default handle positions. I don't know if you're willing to merge this without generic support for all nodes, but IMO it's better than the current default behavior.

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2023

⚠️ No Changeset found

Latest commit: 6c03349

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-flow-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 5:22pm
vue-flow-typedoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 5:22pm

@vercel
Copy link

vercel bot commented Jun 19, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @bcakmakoglu on Vercel.

@bcakmakoglu first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc June 19, 2023 16:10 Inactive
@bcakmakoglu
Copy link
Owner

Hey, thanks for the PR.
As you mentioned, I'd rather have a "fix" for this that applies to all edge types instead of just smoothstep edges.
I'll give it a look though and if possible add it to one of the next minor releases :)

@bcakmakoglu bcakmakoglu changed the title Make loopback edges appear nicely feat(core): make loopback edges appear nicely Jun 20, 2023
@bcakmakoglu bcakmakoglu self-assigned this Jun 20, 2023
@bcakmakoglu bcakmakoglu added the enhancement New feature or request label Jun 20, 2023
@atyshka
Copy link
Author

atyshka commented Jun 20, 2023

Ok, adding regular step edges is trivial, and I could probably figure out something for bezier

@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc June 21, 2023 20:53 Inactive
@atyshka
Copy link
Author

atyshka commented Jun 21, 2023

Ok, I just updated my PR. Bezier edges and horizontal handles now work correctly.

FYI - In my testing, edge type "simple-bezier" was rendering as regular bezier. I used vue devtools and it seems that the type passed to EdgeWrapper was false, and then EdgeWrapper selects the default edge type. You may want to look into that

@bcakmakoglu
Copy link
Owner

I might have to reject this PR, solely on the basis that all edge utils will be removed from this repo in favor of @xyflow/system (the base pkg on which React Flow is going to be built, in "beta" currently but a PR for integrating the pkg exists #1017)

Repository owner deleted a comment from sonarcloud bot May 12, 2024
@bcakmakoglu bcakmakoglu force-pushed the master branch 4 times, most recently from 820ed06 to d71de0a Compare June 10, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants