av-embeds
- AMP Articles to use parentPID
instead of versionPID
#12165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA [number]
Overall changes
externalEmbedUrl
URLs for Optimo Articles av-embeds to use theparentPID
value, rather thanversionPID
when requesting a media asset. The BFF can handle either theparentPID
orversionPID
, and in these cases using theparentPID
should somewhat help resolve requests for media assets that no longer existCode changes
parentPID
param into AMP and external URL constructors, using this value for Optimo Articles onlyTesting
https://web-cdn.api.bbci.co.uk
-simorgh/src/app/components/MediaLoader/utils/urlConstructors.ts
Line 8 in cbee84c
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines