Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

av-embeds - AMP Articles to use parentPID instead of versionPID #12165

Draft
wants to merge 7 commits into
base: latest
Choose a base branch
from

Conversation

amoore108
Copy link
Contributor

@amoore108 amoore108 commented Nov 12, 2024

Resolves JIRA [number]

Overall changes

  • Amends the AMP and externalEmbedUrl URLs for Optimo Articles av-embeds to use the parentPID value, rather than versionPID when requesting a media asset. The BFF can handle either the parentPID or versionPID, and in these cases using the parentPID should somewhat help resolve requests for media assets that no longer exist

Code changes

  • Passes new parentPID param into AMP and external URL constructors, using this value for Optimo Articles only

Testing

  1. Update this line to be https://web-cdn.api.bbci.co.uk -
    const TEST_AMP_URL = 'https://web-cdn.test.api.bbci.co.uk';
  2. Visit http://localhost.bbc.com:7080/news/articles/cde7ng85jwgo.amp?renderer_env=live
  3. Confirm the media player renders and is playable
  4. Visit legacy CPS page: http://localhost.bbc.com:7080/serbian/cyr/srbija-68707945.amp?renderer_env=live
  5. Confirm the media player renders and is playable

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@amoore108 amoore108 self-assigned this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant