-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring meson, make and pkgconfig versions via bzlmod exten… #1158
base: main
Are you sure you want to change the base?
Conversation
4190892
to
db70d73
Compare
61213e6
to
289b9c6
Compare
foreign_cc/meson.bzl
Outdated
main = "@meson_src//:meson.py", | ||
data = ["@meson_src//:runtime"], | ||
main = "@meson_1.1.1_src//:meson.py", | ||
data = ["@meson_1.1.1_src//:runtime"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jheaff1 any ideas how I could avoid this hardcoded version number?
I want the end user to not have to do use_repo(tools, "meson_src") if they're using this macro which they currently have to; maybe we should make the toolchain variants have to be declared via a module extension and then generate this toolchain into the toolchain_hub e.g.
tools.meson(version = "1.1.1")
tools.meson(version = "1.1.1", requirements = ["@pypi__numpy"])
?
@jheaff1 @UebelAndre One part of this I'm yet to design is what the module extension should look like for selecting between preinstalled tools and prebuilt / built from source tools. Any ideas? The extension API currently looks like this:
we could do something like:
but very much open to ideas on this. |
69ccaa7
to
bf9f34b
Compare
bf9f34b
to
727f549
Compare
55ea21b
to
e83ede3
Compare
e83ede3
to
b6938f8
Compare
…sion