Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Assertion doesn't handle failed check #89

Open
dhalperi opened this issue Feb 27, 2020 · 0 comments
Open

Assertion doesn't handle failed check #89

dhalperi opened this issue Feb 27, 2020 · 0 comments

Comments

@dhalperi
Copy link
Member

The questions underlying Batfish assertions can fail, in which case the Answer returned will not be a TableAnswer. In at least one case, the check is not handling this case well: instead of getting the error, we get:

fatal: [localhost]: FAILED! => {"changed": false, "msg": "1 of 1 assertions failed", "result": [{"details": "'Answer' object has no attribute 'frame'", "name": "Confirm routers can ping each other", "status": "Error", "type": "assert_all_flows_succeed"}], "summary": "1 of 1 assertions failed"}

(see: https://networktocode.slack.com/archives/CCE02JK7T/p1582840013048800)

Batfish should always check the answer type before calling .frame().

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant