Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #1081

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Fix tests #1081

merged 2 commits into from
Apr 19, 2022

Conversation

MaryamZi
Copy link
Member

Purpose

$title.

rdulmina
rdulmina reviewed Apr 18, 2022
View reviewed changes
conformance/lang/expressions/multiplicative-expr/multiplicative_expr.balt Outdated
@@ -6,9 +6,6 @@ function errorFunction(int a, float b) {
int _ = a * b; // @error * is not allowed with operands of different basic types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is allowed now. The error here is the result type is float. Let's check the other similar places as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test in b890cb7.

conformance/lang/expressions/multiplicative-expr/multiplicative_expr.balt
@@ -17,7 +14,7 @@ Labels: multiplicative-expr, int, float, decimal

function errorFunction(int a, float b, decimal c) {
int _ = a * c; // @error * is not allowed with operands of different basic types
decimal _ = c / a; // @error / is not allowed with operands of different basic types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some set of output tests as well to cover allowed combinations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, already created ballerina-platform/ballerina-lang#35826. This PR is to just get the existing tests to pass.

@MaryamZi MaryamZi requested a review from rdulmina April 18, 2022 06:44
@MaryamZi MaryamZi merged commit 4f3b8c3 into ballerina-platform:conformance-tests Apr 19, 2022
@MaryamZi MaryamZi deleted the fix-tests branch April 19, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdulmina rdulmina rdulmina approved these changes

@chiranSachintha chiranSachintha Awaiting requested review from chiranSachintha

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

@rdhananjaya rdhananjaya Awaiting requested review from rdhananjaya rdhananjaya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaryamZi @rdulmina