-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conformance tests for transactional-expr #1054
Add conformance tests for transactional-expr #1054
Conversation
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
@lasinicl are these passing locally? for me "28 tests completed, 22 failed" |
I think they are failing with the test runner because transactions require |
We have |
a += 6; | ||
} | ||
} else { | ||
check commit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an error? Since commit cannot be invoked outside a transactional mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. we can probably do that. 🤔 It would be a breaking change though 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a issue please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you manage to run the test-runner atm? |
The test runner implementation is in a separate branch. https://github.com/ballerina-platform/ballerina-lang/tree/spec-conformance-test-runner |
No, I meant the ballerinai/transaction depended ones? |
We can't really run these tests successfully using the test runner ATM due to this restriction. |
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
…ina-spec into transactional-expr
@chiranSachintha @lasinicl merging this will break the test runner in lang; shall we skip |
conformance/lang/expressions/transactional-expr/transactional_expr.balt
Outdated
Show resolved
Hide resolved
Will be handled via ballerina-platform/ballerina-lang#35943 |
Purpose
Fixes ballerina-platform/ballerina-lang#34998