Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement list semtype in runtime #42870

Conversation

heshanpadmasiri
Copy link
Member

Purpose

$subject

Fixes #42869

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@heshanpadmasiri heshanpadmasiri force-pushed the exp/runtime-list branch 5 times, most recently from 9467e93 to 64d9c9f Compare June 10, 2024 01:46
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 78.03172% with 471 lines in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (843bb40) to head (29c0fde).
Report is 15 commits behind head on nutcracker.

Files Patch % Lines
...untime/internal/types/semtype/BBooleanSubType.java 25.67% 41 Missing and 14 partials ⚠️
...runtime/internal/types/semtype/BStringSubType.java 49.42% 37 Missing and 7 partials ⚠️
...rina/runtime/internal/types/semtype/BListProj.java 60.63% 28 Missing and 9 partials ⚠️
...a/io/ballerina/runtime/api/types/semtype/Core.java 80.66% 21 Missing and 14 partials ⚠️
...untime/internal/types/semtype/BDecimalSubType.java 45.31% 26 Missing and 9 partials ⚠️
...na/runtime/internal/types/semtype/BIntSubType.java 79.88% 21 Missing and 13 partials ⚠️
...erina/runtime/api/types/semtype/SemTypeHelper.java 0.00% 29 Missing ⚠️
.../runtime/internal/types/semtype/BFloatSubType.java 60.27% 17 Missing and 12 partials ⚠️
...a/runtime/internal/types/semtype/BCellSubType.java 66.66% 15 Missing and 8 partials ⚠️
...a/runtime/internal/types/semtype/BListSubType.java 89.74% 12 Missing and 8 partials ⚠️
... and 28 more
Additional details and impacted files
@@               Coverage Diff                @@
##             nutcracker   #42870      +/-   ##
================================================
- Coverage         77.38%   77.35%   -0.03%     
- Complexity        52454    53071     +617     
================================================
  Files              2997     3038      +41     
  Lines            208035   210205    +2170     
  Branches          27222    27641     +419     
================================================
+ Hits             160987   162609    +1622     
- Misses            38189    38578     +389     
- Partials           8859     9018     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heshanpadmasiri heshanpadmasiri force-pushed the exp/runtime-list branch 2 times, most recently from a74789e to f91d722 Compare June 20, 2024 03:22
@lochana-chathura lochana-chathura added Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Area/SemtypeIntegration Issue related to integrating semtype engine labels Jun 28, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

Copy link

github-actions bot commented Aug 8, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@heshanpadmasiri
Copy link
Member Author

Closed in favour of #43279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemtypeIntegration Issue related to integrating semtype engine Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants