Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Support for Generation of Optional Record Fields and Proper Namespaces #41594

Conversation

AzeemMuzammil
Copy link
Member

Purpose

This PR contains improvements to the XML to Record converter tools, below are the improvements added.

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@AzeemMuzammil AzeemMuzammil changed the title Implement Support for Generation on Optional Record Fields and Proper Namespaces Implement Support for Generation of Optional Record Fields and Proper Namespaces Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (75f1758) 76.71% compared to head (325c43b) 76.74%.
Report is 367 commits behind head on master.

Files Patch % Lines
...rina/xmltorecordconverter/util/ConverterUtils.java 62.85% 10 Missing and 3 partials ⚠️
...ina/xmltorecordconverter/XMLToRecordConverter.java 93.19% 4 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #41594      +/-   ##
============================================
+ Coverage     76.71%   76.74%   +0.02%     
- Complexity    52734    52758      +24     
============================================
  Files          2878     2878              
  Lines        198735   198848     +113     
  Branches      25832    25846      +14     
============================================
+ Hits         152453   152598     +145     
+ Misses        37869    37820      -49     
- Partials       8413     8430      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Dec 15, 2023
@AzeemMuzammil AzeemMuzammil merged commit 28e7a41 into ballerina-platform:master Dec 18, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants