Support record defaultable fields with closure values for runtime #40579

HindujaB · 2023-06-02T09:49:19Z

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #40805
Fixes #40214
Fixes #37351
Fixes #40943
Fixes #41234
Fixes #41378
Fixes #41219
Fixes #33771
Fixes #32012
Fixes #38558

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

…ina-lang into closures-for-record-default-values � Conflicts: � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/BIRPackageSymbolEnter.java � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmDesugarPhase.java � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SymbolResolver.java

…ina-lang into closures-for-record-default-values � Conflicts: � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/util/ImmutableTypeCloner.java � tests/jballerina-debugger-integration-test/src/test/java/org/ballerinalang/debugger/test/adapter/variables/VariableVisibilityTest.java � tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/javainterop/DependentlyTypedFunctionsTest.java

…ina-lang into closures-for-record-default-values � Conflicts: � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java � misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/evaluation/engine/action/RemoteMethodCallActionEvaluator.java � misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/utils/PackageUtils.java

…github.com/ballerina-platform/ballerina-lang into closures-for-record-default-values � Conflicts: � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java � tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/javainterop/DependentlyTypedFunctionsTest.java

…github.com/ballerina-platform/ballerina-lang into closures-for-record-default-values

…ina-lang into closures-for-record-default-values � Conflicts: � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/creators/JvmRecordCreatorGen.java

…ina-lang into closures-for-record-default-values � Conflicts: � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/types/BLangObjectTypeNode.java

…ina-lang into closures-for-record-default-values � Conflicts: � .github/workflows/pull_request_windows_build.yml

…jaB/ballerina-lang into closures-for-record-default-values

… into closures-for-record-default-values

…jaB/ballerina-lang into closures-for-record-default-values

… into closures-for-record-default-values

...ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/model/BIRNonTerminator.java

bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/constants/RuntimeConstants.java

MaryamZi · 2023-11-23T09:34:48Z

docs/bir-spec/src/main/resources/kaitai/bir.ksy

      - id: type_inclusions_count
        type: s4
      - id: type_inclusions_cp_index
        type: s4
        repeat: expr
        repeat-expr: type_inclusions_count
+      - id: default_values


Shall we update the BIR version?

Updated f0dcb27

MaryamZi · 2023-11-23T09:41:39Z

...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java

+        return !hasMissingRequiredFields;
+    }
+
+    private void findDefaultValuesFromEnclosingPackage(List<BLangTypeDefinition> typeDefinitions,


Ping on this.

...src/main/java/org/wso2/ballerinalang/compiler/semantics/model/symbols/BRecordTypeSymbol.java

MaryamZi · 2023-11-23T09:44:22Z

.../ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/util/TypeDefBuilderHelper.java

@@ -319,6 +302,7 @@ public static void populateStructureFields(Types types, SymbolTable symTable,
                                               long flag, boolean isImmutable) {
        BTypeSymbol structureSymbol = structureType.tsymbol;
        LinkedHashMap<String, BField> fields = new LinkedHashMap<>();
+        structureType.typeInclusions = origStructureType.typeInclusions;


Why did we need to add this? May have to rename the method too, since it does more than populate structure fields.

type Foo record {| int[] x = [1]; int[] y = []; |}; type Bar record {| *Foo; int[] & readonly x = [2]; |}; public function main() { Bar & readonly b1 = {}; io:println(b1); }

When considering the above scenario , we need to create an immutable type for 'Bar.' When doing that, we need to include type inclusions into the newly generated type. For that I do the above change.

Change function name as populateStructureFieldsAndTypeInclusions

…ina-lang into closures-for-record-default-values # Conflicts: # langlib/langlib-test/src/test/java/org/ballerinalang/langlib/test/LangLibValueTest.java

MaryamZi

Approving based on several reviews of mostly the compiler changes and testing.

Nadeeshan96

LGTM

…ina-lang into closures-for-record-default-values

warunalakshitha

LGTM

chiranSachintha added 30 commits July 31, 2022 22:01

Create closures for default values of record fields

b091f8e

Updates fields of record literals

8239d79

Refactor closure symbol mark logic

a1edca9

Add flag to record fields withs default values

77f35a8

Remove initFunction from record type node

d55e2e2

Remove initializerFunc from record type symbol

830edc6

Introduce default values to record type symbol

a75558f

Update instantiate record values logic

98c8d6b

Remove initializer from record type

1b7ee69

Remove enclMapSymbols from BLangStructLiteral

8325e40

Resolve conflicts

5922082

Add default values info in the BIR

5eaa9f4

Updates fields of record literals

bc27195

Add default values to ksy file

9c69ed9

Remove duplicate visit function

f042529

Add tests for record type

7b44339

Enable builds on the closure branch

6ab8659

Merge branch 'closure-changes-for-function-defult-values' of https://…

f34be4e

…github.com/ballerina-platform/ballerina-lang into closures-for-record-default-values

Set closures from the mutable type

ad672c7

Merge branch 'master' of https://github.com/ballerina-platform/baller…

3a80a18

…ina-lang into closures-for-record-default-values � Conflicts: � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/creators/JvmRecordCreatorGen.java

Resolve conflicts

6fe9727

Rename ParameterDesugar to GenerateClosuresForDefaultValues

5868535

Merge branch 'master' of https://github.com/ballerina-platform/baller…

ad68c3f

…ina-lang into closures-for-record-default-values � Conflicts: � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/types/BLangObjectTypeNode.java

fix review suggestions

7c5487b

Merge branch 'master' of https://github.com/ballerina-platform/baller…

4ba8e40

…ina-lang into closures-for-record-default-values � Conflicts: � .github/workflows/pull_request_windows_build.yml

fix review suggestions

bef24be

HindujaB and others added 3 commits October 30, 2023 10:21

Merge branch 'closures-for-record-default-values' of github.com:Hindu…

2a38df3

…jaB/ballerina-lang into closures-for-record-default-values

Add unit tests

4a50986

Fix review suggestions

e4d495a

chiranSachintha force-pushed the closures-for-record-default-values branch from 4d8ac48 to e4d495a Compare November 1, 2023 04:57

HindujaB added 9 commits November 1, 2023 11:00

Move record default to separate instruction

d3da6ad

Merge branch 'master' of github.com:ballerina-platform/ballerina-lang…

e3680fc

… into closures-for-record-default-values

Merge branch 'closures-for-record-default-values' of github.com:Hindu…

e099065

…jaB/ballerina-lang into closures-for-record-default-values

Fix checkstyle error

ce56e63

Fix merge conflicts

b295ff7

Fix checkstyle error

1d9651c

Merge branch 'master' of github.com:ballerina-platform/ballerina-lang…

0c2ff07

… into closures-for-record-default-values

Fix merge conflicts

5bdcf45

Fix checkstyle error

eeedf3f

Nadeeshan96 reviewed Nov 22, 2023

View reviewed changes

...ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/model/BIRNonTerminator.java Show resolved Hide resolved

Nadeeshan96 reviewed Nov 22, 2023

View reviewed changes

...ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/model/BIRNonTerminator.java Show resolved Hide resolved

HindujaB added 3 commits November 23, 2023 12:05

Fix merge conflicts

fd187f5

Add javadoc comment

f481535

Fix checkstyle error

b5d8788

MaryamZi reviewed Nov 23, 2023

View reviewed changes

chiranSachintha added 5 commits November 24, 2023 10:52

Merge branch 'master' of https://github.com/ballerina-platform/baller…

459db87

…ina-lang into closures-for-record-default-values # Conflicts: # langlib/langlib-test/src/test/java/org/ballerinalang/langlib/test/LangLibValueTest.java

Update bir version numbers

f0dcb27

Fix review suggestions

263578c

Fix checkstyle error

96ac2d3

Add comment

8b352da

MaryamZi approved these changes Nov 27, 2023

View reviewed changes

Nadeeshan96 approved these changes Dec 4, 2023

View reviewed changes

Merge branch 'master' of https://github.com/ballerina-platform/baller…

42c4311

…ina-lang into closures-for-record-default-values

warunalakshitha approved these changes Dec 6, 2023

View reviewed changes

chiranSachintha merged commit 5ae9d10 into ballerina-platform:master Dec 6, 2023
17 of 18 checks passed

chiranSachintha mentioned this pull request Dec 8, 2023

[Bug]: NoSuchMethodError exception when running with tuple destructure #41174

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support record defaultable fields with closure values for runtime #40579

Support record defaultable fields with closure values for runtime #40579

HindujaB commented Jun 2, 2023 •

edited by chiranSachintha

Loading

MaryamZi Nov 23, 2023

chiranSachintha Nov 24, 2023

MaryamZi Nov 23, 2023

MaryamZi Nov 23, 2023

chiranSachintha Nov 24, 2023

chiranSachintha Nov 24, 2023

MaryamZi left a comment

Nadeeshan96 left a comment

warunalakshitha left a comment

Support record defaultable fields with closure values for runtime #40579

Support record defaultable fields with closure values for runtime #40579

Conversation

HindujaB commented Jun 2, 2023 • edited by chiranSachintha Loading

Purpose

Approach

Samples

Remarks

Check List

MaryamZi Nov 23, 2023

Choose a reason for hiding this comment

chiranSachintha Nov 24, 2023

Choose a reason for hiding this comment

MaryamZi Nov 23, 2023

Choose a reason for hiding this comment

MaryamZi Nov 23, 2023

Choose a reason for hiding this comment

chiranSachintha Nov 24, 2023

Choose a reason for hiding this comment

chiranSachintha Nov 24, 2023

Choose a reason for hiding this comment

MaryamZi left a comment

Choose a reason for hiding this comment

Nadeeshan96 left a comment

Choose a reason for hiding this comment

warunalakshitha left a comment

Choose a reason for hiding this comment

HindujaB commented Jun 2, 2023 •

edited by chiranSachintha

Loading