[Bug]: Getting a NoSuchFieldError when running tests for Ballerina IO package with Dead code elimination

[ayeshLK]

Description

$subject

Steps to Reproduce

1. Update Ballerina lang version to 2201.11.0-20241101-105200-f94714be in the gradle.properties.

2. Build Ballerina IO module (using gradle) and there will be an intermediate pack constructed in <project-root>/target/ballerina-runtime.

3. Run the following command.

BAL_DISABLE_HARDCODED_OPTIMIZATIONS=true <path-to-intermediate-pack>/bin/bal test --eliminate-dead-code --dead-code-elimination-report

Affected Version(s)

Ballerina Lang version 2201.11.0-20241101-105200-f94714be

OS, DB, other environment details and versions

No response

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

[MaryamZi]

Without adding the annotations, if we use BAL_DISABLE_HARDCODED_OPTIMIZATIONS, errors are expected.

This may still be a bug though. In the report, toTableExtern is identified as used, but it seems like the anonymous record member type of the table type in the return type is getting removed.

[MaryamZi]

The issue seems to be due to the isTestablePkgImportedModuleDependency check incorrectly returning true for in-line types like tables (and probably maps, arrays, etc.), since their package IDs are the lang.annotation package's package ID.

[MaryamZi]

When we special case such types the original errors go away, but then I see errors similar to that reported in #43552.

diff --git a/compiler/ballerina-lang/src/main/java/io/ballerina/projects/UsedTypeDefAnalyzer.java b/compiler/ballerina-lang/src/main/java/io/ballerina/projects/UsedTypeDefAnalyzer.java
index 0fb5137c051..d0e16870aa5 100644
--- a/compiler/ballerina-lang/src/main/java/io/ballerina/projects/UsedTypeDefAnalyzer.java
+++ b/compiler/ballerina-lang/src/main/java/io/ballerina/projects/UsedTypeDefAnalyzer.java
@@ -20,6 +20,7 @@ package io.ballerina.projects;
 import org.wso2.ballerinalang.compiler.PackageCache;
 import org.wso2.ballerinalang.compiler.bir.model.BIRNode;
 import org.wso2.ballerinalang.compiler.semantics.model.SimpleBTypeAnalyzer;
+import org.wso2.ballerinalang.compiler.semantics.model.SymbolTable;
 import org.wso2.ballerinalang.compiler.semantics.model.types.BType;
 import org.wso2.ballerinalang.compiler.util.CompilerContext;
 import org.wso2.ballerinalang.compiler.util.TypeTags;
@@ -43,11 +44,13 @@ public final class UsedTypeDefAnalyzer extends SimpleBTypeAnalyzer<UsedTypeDefAn
     private final Set<BType> visitedTypes = new HashSet<>();
     private final PackageCache pkgCache;
     private final UsedBIRNodeAnalyzer usedBIRNodeAnalyzer;
+    private final SymbolTable symbolTable;
 
     private UsedTypeDefAnalyzer(CompilerContext context) {
         context.put(BIR_TYPE_DEF_ANALYZER_KEY, this);
         this.pkgCache = PackageCache.getInstance(context);
         this.usedBIRNodeAnalyzer = UsedBIRNodeAnalyzer.getInstance(context);
+        this.symbolTable = SymbolTable.getInstance(context);
     }
 
     public static UsedTypeDefAnalyzer getInstance(CompilerContext context) {
@@ -177,6 +180,7 @@ public final class UsedTypeDefAnalyzer extends SimpleBTypeAnalyzer<UsedTypeDefAn
         }
 
         return usedBIRNodeAnalyzer.isTestablePkgAnalysis &&
+                !bType.tsymbol.pkgID.equals(symbolTable.langAnnotationModuleSymbol.pkgID) && // built-in types
                 !bType.tsymbol.pkgID.equals(usedBIRNodeAnalyzer.currentPkgID);
     }

[MaryamZi]

We've added some fixes which are available with 2201.11.0-20241111-101700-af28a18f, can you please check with this version?

[MaryamZi]

Fixed in #43557.