Review how LS features going to work on top of a partially compiled AST

[lochana-chathura]

Description:
$subject.

1. When the compiler crashes currently we catch the exception and add a compiler diagnostic saying "Compilation failed due to: ".
   In this scenario, the compilation is only partially done. But, the LS is not aware of it. So LS features working on top of such a situation could lead to wrong suggestions, etc.

2. There could be LS test cases that are false positives because they are written on top of a partial compilation. With PR Fix unhandled compiler exceptions being not result in test failures #34984 if there is any such test case that will fail. (But this is only a temporary solution).

3. As @pubudu91 said we use the same compilationContext between subsequent compilations. If there is a crash, we need to flush it to avoid any unpredictable results.

[1] and [2] are somewhat okay for now. But, we need to fix [3] immediately.

[pubudu91]

Had an offline chat with the others regarding this. The conclusion was that [3] is what we need to actively work on fixing. Created #35158 to track this.

[lochana-chathura]

Please find the meeting notes on the latest discussion here.

[anupama-pathirage]

We are closing this issue due to inactivity. If you need further assistance or have additional input, feel free to reopen it. Thank you for helping us maintain a relevant and focused issue list!