Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoW AMM swap detection #173

Open
agualis opened this issue Nov 20, 2024 · 5 comments
Open

CoW AMM swap detection #173

agualis opened this issue Nov 20, 2024 · 5 comments
Assignees

Comments

@agualis
Copy link
Collaborator

agualis commented Nov 20, 2024

Swapping from WETH to EUL is failing with:

  • Pool swap:
    SDK does not support swap for vault version 1

  • Standard swap:
    There's not enough liquidity on Balancer connecting there tokens to route this swap.

Xeonus answer:
CoWAMM pools have a 99% swap fee by design. Only CoW solvers can tap into that liquidity to capture LVR. You need to use the cowswap UI to trade: https://swap.cow.fi/#/1/swap/WETH/EUL

Should we improve the UI/UX for these edge-cases?

@agualis agualis self-assigned this Nov 20, 2024
@garethfuller
Copy link
Contributor

Do you have a suggestion for how to improve the UX here?

@agualis
Copy link
Collaborator Author

agualis commented Nov 21, 2024

Do you have a suggestion for how to improve the UX here?

Should we link to CoW swap when detecting this edge case? If not, at least, we should change the error text with a better explanation.

@Zen-Maxi
Copy link

Knee jerk reaction is to have cowswap integrated for cowAmm swaps specifically on our site. Then users don't need to link anywhere else to get their swap through. Similar to what @agualis suggested. At a minimum a link to cowswaps site saying they must use cowswap to be routed through the pool. Any strong reason to not bring back the cowswap toggle on our frontend ? Maker/sky guys mentioned missing it.

@garethfuller
Copy link
Contributor

@Zen-Maxi the reason not to bring the cowswap toggle back is that we don't have the capacity to maintain the integration and make the UX great. We will never be able to provide as good a UX as Cowswap. imo the best approach would be to find a nice way to redirect the user to Cowswap in this case.

@Xeonus
Copy link

Xeonus commented Nov 21, 2024

My take for the time-being as a simple solution:

  • remove direct swap feature on CoWAMM pools and replace with hyperlink to CoWSwap, can be easily built based on page sate, e.g. https://swap.cow.fi/#/1/swap/WETH/EUL
  • on our swap UI, if no swap route is found, offer cow redirect similar to the one above

This approach would simplify things while not causing too much dev effort. Just an idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants