Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook review support #151

Open
garethfuller opened this issue Nov 7, 2024 · 2 comments · May be fixed by #163
Open

Hook review support #151

garethfuller opened this issue Nov 7, 2024 · 2 comments · May be fixed by #163
Assignees
@groninge01
Labels
v3
Milestone
V3 Support

Comments

@garethfuller
Copy link
Contributor

We need to handle hook reviews in the same way we handle rate provider reviews on pool pages.

  • Render the information
  • Block actions and display warnings under certain conditions.

Designs: https://www.figma.com/design/97sJd9iKmVWDsPIUdHGxTk/v3-App-Pools-Launch?node-id=0-1&t=FqwfjgPU5WOdvOwr-1
@garethfuller
Copy link
Contributor Author

Pool with hook: http://localhost:3000/pools/sepolia/v3/0x75F49D54978d08E4E76a873dA6c78E8f6b2901C2

@garethfuller garethfuller added the v3 label Nov 7, 2024
@garethfuller garethfuller added this to the V3 Support milestone Nov 7, 2024
@groninge01
Copy link
Contributor

groninge01 commented Nov 14, 2024 •
edited
Loading

@garethfuller how do we handle nested pools with a hook in Pool Contracts?

update 20-11: busy with suggestion for this

@groninge01 groninge01 linked a pull request Nov 15, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@groninge01 groninge01

Labels
v3
Projects
None yet
Milestone
V3 Support
Development

Successfully merging a pull request may close this issue.

feat: add hook data support balancer/frontend-monorepo
2 participants
@garethfuller @groninge01