Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/enable hooks sor #896

Draft
wants to merge 19 commits into
base: v3-canary
Choose a base branch
from
Draft

Feat/enable hooks sor #896

wants to merge 19 commits into from

Conversation

mkflow27
Copy link
Contributor

@mkflow27 mkflow27 commented Sep 4, 2024

This pr is a WIP to enable hooks in the SOR. There are various assumptions made that need to be verified.
This pr has these tests currently working:

  • weightedPool.test.ts
  • stablePool.test.ts
  • balancer-sor.integration.test.ts

I'll list some points with outstanding questions:

  • Hook fetching & handling. Where would be the best place to attach the correct hook to the correct pool. Currently this is happening as part of every V3pool's fromPrismaPool.
  • What should getHookState() return if a pool does not have a hook?
  • Why are tokens part of the HookState or is this mean to signal which tokens the fee applies to?

Currently missing tasks:

  • Add a getBaseHooksFromDb in the SorPathService

Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: 393023e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant