-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add srain_piezo of WS90 for rain state detection #1115
Conversation
What tests should I implement for srain_piezo to achieve successful checks? |
I would take a look at these tests as inspiration: #1115 (comment) |
Thank you for giving me some hint. However, this link seems to be wrong. |
Apologies! https://github.com/bachya/ecowitt2mqtt/blob/dev/tests/data/test_data_processing.py |
0129df9
to
f89997e
Compare
bc53bea
to
3012aef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1115 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 33 +1
Lines 1775 1789 +14
=========================================
+ Hits 1775 1789 +14 ☔ View full report in Codecov by Sentry. |
It took me some time familiarising with pytest and the CI pipeline. I hope, my implementation is appropriate. From my point of view, this should be ready to merge, please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks so much!
Adds rain state detection, which is available since GW2000 firmware 3.1.5
Fixes #1102
Checklist:
README.md
with any new documentation.