fix: Ignore duplicated sig error (#30)

* ignore duplicated sig error

* changelog

CHANGELOG.md

@@ -37,6 +37,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 ## Unreleased
 
+### Bug fixes
+
+* [#30](https://github.com/babylonlabs-io/covenant-emulator/pull/30) Ignore duplicated sig error
+
 ### Improvements
 
 * [#22](https://github.com/babylonlabs-io/covenant-emulator/pull/22) Go releaser setup

clientcontroller/babylon.go

@@ -176,6 +176,10 @@ func (bc *BabylonController) SubmitCovenantSigs(covSigs []*types.CovenantSigs) (
 		return nil, err
 	}
 
+	if res == nil {
+		return &types.TxResponse{}, nil
+	}
+
 	return &types.TxResponse{TxHash: res.TxHash, Events: res.Events}, nil
 }
 

clientcontroller/retry_utils.go

@@ -12,4 +12,6 @@ var unrecoverableErrors = []*sdkErr.Error{
 	btcstakingtypes.ErrInvalidCovenantSig,
 }
 
-var expectedErrors = []*sdkErr.Error{}
+var expectedErrors = []*sdkErr.Error{
+	btcstakingtypes.ErrDuplicatedCovenantSig,
+}

itest/e2e_test.go

@@ -6,6 +6,8 @@ package e2etest
 import (
 	"testing"
 	"time"
+
+	"github.com/stretchr/testify/require"
 )
 
 var (
@@ -37,5 +39,14 @@ func TestCovenantEmulatorLifeCycle(t *testing.T) {
 	time.Sleep(10 * time.Second)
 
 	// check the BTC delegation is verified
-	_ = tm.WaitForNVerifiedDels(t, 1)
+	dels := tm.WaitForNVerifiedDels(t, 1)
+
+	// test duplicate, should expect no error
+	// remove covenant sigs
+	dels[0].CovenantSigs = nil
+	dels[0].BtcUndelegation.CovenantSlashingSigs = nil
+	dels[0].BtcUndelegation.CovenantUnbondingSigs = nil
+	res, err := tm.CovenantEmulator.AddCovenantSignatures(dels)
+	require.NoError(t, err)
+	require.Empty(t, res)
 }