chore: bump wasmd and re-enable static linking #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianElvis
requested review from
gitferry and
RafilxTenfen
and removed request for
a team
SebastianElvis
requested review from
KonradStaniec and
maurolacy
and removed request for
gitferry
SebastianElvis
commented
Oct 21, 2024
|
|
||
| # Label should match your github repo | ||
| ARG VERSION |
There was a problem hiding this comment.
NOTE: this line addresses the warning of GH action on Dockerfiles
KonradStaniec
approved these changes
Oct 21, 2024
maurolacy
reviewed
Oct 25, 2024
Comment on lines
+58
to
+60
| # Install Libraries | ||
| # COPY --from=build-env /usr/lib/libgcc_s.so.1 /lib/ | ||
| # COPY --from=build-env /lib/ld-musl*.so.1* /lib |
There was a problem hiding this comment.
Nit: remove commented code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
Also addresses the GH action warning on Dockerfiles
NOTE:
init.Dockerfilestill uses dynamic linking because it builds v0.9.3. This can only be fixed in the v2 upgrade, unless we release v0.9.4 with this PR backported (which I don't think it's the case).