Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add goreleaser setup and move out changelog reminder #170

Merged
merged 7 commits into from
Oct 11, 2024
Merged

ci: add goreleaser setup and move out changelog reminder #170

merged 7 commits into from
Oct 11, 2024

Conversation

SebastianElvis
Copy link
Member

@SebastianElvis SebastianElvis commented Oct 11, 2024 •
edited
Loading

This PR

  • sets up Go releaser for Babylon. Currently it only supports linux amd64. Other targets will be supported in the future. To test locally, run make release-snapshot
  • moves changelog reminder out from the CI flow

@SebastianElvis SebastianElvis marked this pull request as ready for review October 11, 2024 04:36
@SebastianElvis SebastianElvis requested a review from a team as a code owner October 11, 2024 04:36
@SebastianElvis SebastianElvis requested review from gitferry and KonradStaniec and removed request for a team October 11, 2024 04:36
@SebastianElvis
Copy link
Member Author

SebastianElvis commented Oct 11, 2024 •
edited
Loading

Hmm any idea why changelog reminder is not happy with the error not a PR 😅

UPDATE: OK resolved by moving it out following Osmosis' practice. Now ready for review

@SebastianElvis SebastianElvis changed the title goreleaser: add goreleaser setup ci: add goreleaser setup and move out changelog reminder Oct 11, 2024
KonradStaniec
KonradStaniec approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Maybe we could update RELEASE_PROCESS.md file to indicate when binaries will be build ? I imagine it would be when tagging release branch ?

@SebastianElvis
Copy link
Member Author

SebastianElvis commented Oct 11, 2024 •
edited
Loading

Maybe we could update RELEASE_PROCESS.md file to indicate when binaries will be build ? I imagine it would be when tagging release branch ?

Yes this is already mentioned. And you are right this is done upon tagging

@KonradStaniec
Copy link
Collaborator

Yes this is already mentioned.

oh I do not see any mentions there, that upon pushing a tag new binaries will be build and published. There is only mention abut backporitng label

@SebastianElvis
Copy link
Member Author

oh I do not see any mentions there, that upon pushing a tag new binaries will be build and published. There is only mention abut backporitng label

Ah you are right! Added

Lazar955
Lazar955 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@Lazar955 Lazar955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

.goreleaser.yml
Comment on lines +22 to +23
- -X github.com/cosmos/cosmos-sdk/version.Version={{ .Version }}
- -X github.com/cosmos/cosmos-sdk/version.Commit={{ .Commit }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 💯

@SebastianElvis SebastianElvis merged commit 23ff41d into main Oct 11, 2024
20 checks passed
@SebastianElvis SebastianElvis deleted the config-goreleaser branch October 11, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lazar955 Lazar955 Lazar955 approved these changes

@KonradStaniec KonradStaniec KonradStaniec approved these changes

@gitferry gitferry Awaiting requested review from gitferry gitferry is a code owner automatically assigned from babylonlabs-io/core-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianElvis @KonradStaniec @Lazar955