Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate inception bbn timestamp needed for UX #47

Open
gusin13 opened this issue Nov 14, 2024 · 4 comments
Open

Investigate inception bbn timestamp needed for UX #47

gusin13 opened this issue Nov 14, 2024 · 4 comments
Assignees

Comments

@gusin13
Copy link
Collaborator

gusin13 commented Nov 14, 2024

No description provided.

@jrwbabylonlab
Copy link
Collaborator

jrwbabylonlab commented Nov 15, 2024

type IndexerDelegationPagination struct {
	StakingTxHashHex string `json:"staking_tx_hash_hex"`
	StartHeight      uint32 `json:"start_height"`
}

once the timestamp value has been added in the indexer db for delegation collection, the pagination token logic in the API service shall also be updated.
Right now the StartHeight is 0 for EOI as there is no such tx exist in BTC yet. We should probably sort by the BBN height or timestamp instead.

i.e we shall save both BBN height and its timestamp in delegation collection @gusin13

fyi @jeremy-babylonlabs

@gusin13
Copy link
Collaborator Author

gusin13 commented Nov 17, 2024

sure can save both, basically we need
eoi_bbn_height
eoi_bbn_timestamp

where inception means EOI is created in babylon

@jrwbabylonlab
Copy link
Collaborator

@gusin13 i think this issue has already been taking care of from your latest api PR, right?

@jrwbabylonlab
Copy link
Collaborator

Please ping in team channel once backend has been released as we need to apply FE changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants