Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Intermediate Artifact page #2

Closed
wants to merge 18 commits into from
Closed

Add Intermediate Artifact page #2

wants to merge 18 commits into from

Conversation

ayushkoli772
Copy link
Owner

No description provided.

@ayushkoli772
Copy link
Owner Author

With this commit I will resolve issue #1 to modify the header and redirect to new intermediate artifact page.

Changes-

image

image

adpi2
adpi2 reviewed Jun 5, 2024
View reviewed changes
Copy link

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

modules/template/src/main/twirl/scaladex/view/project/intermediateArtifacts.scala.html Outdated Show resolved Hide resolved
@ayushkoli772 ayushkoli772 marked this pull request as draft June 5, 2024 14:36
@ayushkoli772
Copy link
Owner Author

Update:

Grouped artifacts by latest version and Passed this to New Artifacts Page
This resolves issue #3

Screenshot:

Screenshot 2024-06-17 at 18-03-38 cats

@adpi2 Please review

@ayushkoli772
Copy link
Owner Author

How it looks-

Screenshot

@adpi2 Please review

@kannupriyakalra
Copy link

Looks good to me :)

@ayushkoli772
Copy link
Owner Author

Improved the UI
This is how it looks-

Improve UI

@adpi2 @kannupriyakalra Please review

@kannupriyakalra
Copy link

Improved the UI This is how it looks-

Improve UI

@adpi2 @kannupriyakalra Please review

this looks nice, good work @ayushkoli772 :)

@ayushkoli772
Copy link
Owner Author

this looks nice, good work @ayushkoli772 :)

Thank you @kannupriyakalra :)

adpi2
adpi2 approved these changes Jul 4, 2024
View reviewed changes
Copy link

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks perfect to me!

@ayushkoli772
Copy link
Owner Author

ayushkoli772 commented Jul 5, 2024 •
edited
Loading

How it looks-

With this I will resolve #4

Improve ui_ artifacts count

Please review. @adpi2 @kannupriyakalra

@ayushkoli772
Copy link
Owner Author

Changes so far

image

adpi2
adpi2 reviewed Aug 12, 2024
View reviewed changes
Copy link

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some help to filter on the binary versions. Once you have the ArtifactsPageParams, it will be easier to set up the pre-release filter and to use it.

modules/server/src/main/scala/scaladex/server/route/ProjectPages.scala Outdated Show resolved Hide resolved
modules/server/src/main/scala/scaladex/server/route/ProjectPages.scala Outdated Show resolved Hide resolved
modules/server/src/main/scala/scaladex/server/route/ProjectPages.scala Outdated Show resolved Hide resolved
@ayushkoli772
Copy link
Owner Author

ayushkoli772 commented Aug 13, 2024 •
edited
Loading

Changes to artifacts page-

image

Changes to versions page-

image

@adpi2 @kannupriyakalra Please review the filtering functionality. There is need to do minor changes to artifacts and versions page. I will do it in subsequent commits.

@ayushkoli772
Copy link
Owner Author

Changes to versions page-

image

@ayushkoli772
Copy link
Owner Author

Minor changes in case there are no artifacts for a version.

Before-
image

After-
image

@adpi2 @kannupriyakalra Please review.

@ayushkoli772
Copy link
Owner Author

@adpi2 I have implemented the suggested changes

adpi2
adpi2 approved these changes Aug 20, 2024
View reviewed changes
Copy link

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I think everything is ready for you to open a PR to https://github.com/scaladex/scaladex, right?

@ayushkoli772
Copy link
Owner Author

Looks good to me!

I think everything is ready for you to open a PR to https://github.com/scaladex/scaladex, right?

Yes! I will make this draft ready for review and then open PR

@ayushkoli772 ayushkoli772 marked this pull request as ready for review August 20, 2024 09:41
@ayushkoli772
Copy link
Owner Author

@adpi2 I should open PR to main branch of scaladex right?

@adpi2
Copy link

adpi2 commented Aug 20, 2024

Yes

@adpi2
Copy link

adpi2 commented Aug 20, 2024

Now that we have scalacenter#1447 could you close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpi2 adpi2 adpi2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushkoli772 @kannupriyakalra @adpi2